Bug #122: requestId for ProgressStartEvent is an integer#123
Merged
weinand merged 1 commit intomicrosoft:gh-pagesfrom Oct 28, 2020
Merged
Bug #122: requestId for ProgressStartEvent is an integer#123weinand merged 1 commit intomicrosoft:gh-pagesfrom
weinand merged 1 commit intomicrosoft:gh-pagesfrom
Conversation
Signed-off-by: Jonah Graham <[email protected]>
Contributor
|
@jonahgraham thanks for the PR. Please note that the schema change does not result in a change of the TypeScript definition used to document the spec. Reason: the schema type "integer" still maps to the "number" type in TypeScript or JavaScript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the trivial part of the fix for #122 - but I couldn't get the generated files to rebuild, so I haven't included manually edited versions.