Repository navigation
Fix Aspire regression scaffolding for package-based templates - #301
Merged
Merged
Conversation
Keep all build directives generated by the daily Aspire CLI instead of requiring a single SDK directive. This supports package-based templates and leaves scaffold validation to Aspire and .NET. Co-authored-by: Copilot App <[email protected]> Copilot-Session: d725021c-e976-45de-abfe-496756b8d520
Ankit Jain (radical)
approved these changes
Oct 19, 2026
Member
Author
|
/backport to release/0.27 |
|
Started backporting to release/0.27: https://github.com/microsoft/dcp/actions/runs/39303260452 |
|
David Negstad (@danegsta) backport PR couldn't be created automatically, please create the backport PR manually! |
This was referenced Oct 19, 2026
Member
Author
|
/backport to release/0.26 |
|
Started backporting to release/0.26: https://github.com/microsoft/dcp/actions/runs/39311149694 |
|
David Negstad (@danegsta) backport PR couldn't be created automatically, please create the backport PR manually! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Aspire regression script assumes the daily CLI generates a
#:sdkdirective and fails when newer templates use package-based configuration instead.Preserve all scaffolded
#:build directives—including SDK/package pins and build properties—before appending the regression AppHost body. Leave scaffold validation to Aspire and .NET rather than requiring a particular directive type.Extracts only the two
test/aspire/file changes from #292, with identical contents. No watcher, API-server, or dependency changes are included; #292 is otherwise unchanged.Validation: shell syntax and whitespace checks pass. Controlled SDK-based, package-based, mixed-directive, and directive-free scaffolds preserve the exact expected directives and AppHost body. Actual Aspire E2E execution is left to the existing PR CI workflow.