Skip to content

Add FluentAssertions.Analyzers to Detectors.Tests, fix warnings#879

Merged
JamieMagee merged 2 commits intomicrosoft:mainfrom
KonH:feature/fluent_assertions_analyzer_usage_in_detectors_tests
Oct 27, 2023
Merged

Add FluentAssertions.Analyzers to Detectors.Tests, fix warnings#879
JamieMagee merged 2 commits intomicrosoft:mainfrom
KonH:feature/fluent_assertions_analyzer_usage_in_detectors_tests

Conversation

@KonH
Copy link
Copy Markdown
Contributor

@KonH KonH commented Oct 26, 2023

Part of #633

@KonH KonH requested a review from a team as a code owner October 26, 2023 22:00
@KonH KonH requested a review from melotic October 26, 2023 22:00
Copy link
Copy Markdown
Member

@melotic melotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! some tests are still failing however :(

@JamieMagee
Copy link
Copy Markdown
Member

Thank you! I'd be happy to merge this once the tests pass 👍

@KonH
Copy link
Copy Markdown
Contributor Author

KonH commented Oct 27, 2023

All tests now passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2023

Codecov Report

Merging #879 (74431ce) into main (4dcff48) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #879   +/-   ##
=====================================
  Coverage   74.8%   74.8%           
=====================================
  Files        235     235           
  Lines       9953    9953           
  Branches     974     974           
=====================================
  Hits        7449    7449           
  Misses      2231    2231           
  Partials     273     273           

@JamieMagee JamieMagee merged commit 53b4059 into microsoft:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants