build: fix dotnet test on certain 9.0.200-preview builds#29
Merged
nguerrera merged 1 commit intomicrosoft:mainfrom Jan 31, 2025
Merged
build: fix dotnet test on certain 9.0.200-preview builds#29nguerrera merged 1 commit intomicrosoft:mainfrom
nguerrera merged 1 commit intomicrosoft:mainfrom
Conversation
nguerrera
requested review from
michaelcfanning,
rwoll and
suvamM
as code owners
nguerrera
force-pushed
the
fix-9.0.200-preview
branch
from
f4d85bf to
ac13095
Compare
For a period, there was breaking SDK change with `PrivateAssets="all"` stripping things from the build `deps.json`. It's been [reverted](dotnet/sdk#46182) but that revert hasn't made it to preview builds of VS yet. While this breaking change is around, having a `PrivateAssets="all"` reference to `Microsoft.NET.Test.Sdk` causes: ``` Testhost process for source(s) 'D:\Src\cask\bld\bin\Cask.Tests\debug_net8.0\Cask.Tests.dll' exited with error: Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.TestPlatform.CoreUtilities, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.` ``` There's no real reason for our `Microsoft.NET.Test.Sdk` reference to have `PrivateAssets="all"` and removing it works around the issue, so this change removes it.
rwoll
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a period, there was breaking SDK change with
PrivateAssets="all"stripping things from the builddeps.json. It's been reverted but that revert hasn't made it to preview builds of VS yet.While this breaking change is around, having a
PrivateAssets="all"reference toMicrosoft.NET.Test.Sdkcauses:There's no real reason for our
Microsoft.NET.Test.Sdkreference to havePrivateAssets="all"and removing it works around the issue, so this change removes it.