Updating VTT hinting code to reflect new point order#746
Merged
Conversation
Collaborator
Author
|
(better not to have 5000 changed files... 😬) |
DHowett
approved these changes
Jun 24, 2024
Member
DHowett
left a comment
DHowett
left a comment
There was a problem hiding this comment.
Thanks for doing this - I'll issue a new canonical version of Cascadia after some spot checks.
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Feb 3, 2025
This update fixes a hinting issue in Arabic glyphs. See microsoft/cascadia-code#746 for more details.
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Feb 3, 2025
This update fixes a hinting issue in Arabic glyphs. See microsoft/cascadia-code#746 for more details.
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Feb 3, 2025
This update fixes a hinting issue in Arabic glyphs. See microsoft/cascadia-code#746 for more details. (cherry picked from commit bf074f3) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgW99Sw Service-Version: 1.21
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Feb 3, 2025
This update fixes a hinting issue in Arabic glyphs. See microsoft/cascadia-code#746 for more details. (cherry picked from commit bf074f3) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgW99S0 Service-Version: 1.22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The point order of certain Arabic glyphs in the font changed, likely due to a newer version of the python libraries. The hinting has now been updated to reflect the new point order.
PR Checklist