Add OVERLAP flag to simple/compound glyphs, fix interpl. error#352
Merged
DHowett merged 20 commits intomicrosoft:masterfrom Sep 14, 2020
Merged
Add OVERLAP flag to simple/compound glyphs, fix interpl. error#352DHowett merged 20 commits intomicrosoft:masterfrom
DHowett merged 20 commits intomicrosoft:masterfrom
Conversation
Decreased Bold weight, added anchors to lowercase Greek, updated GDEF feature builder. Added font linking to STAT.
Reduced weight of bold extreme for better alignment with Regular. Resolved some introduced bugs in hinting and glyph widths.
…Terminal" This reverts commit 91ce4ee.
This reverts commit 25dc61a.
Updating code for the build process and adding in a separate hinting file for the PL glyphs.
Updates build script to include madig's modifications, plus adds static TTF export and autohinting using ttfautohint (if available). Also updated / renamed the Nerdfonts PL file.
- Adjusted box drawing characters for better alignment to the letters - Added anchors to all alphabetic characters (also brevecomb-cy which was missing them) - added a fi and fl ligature (and decompose them so they never show up :) ) - improved weight of horncomb (lowercase) in bold
Changing contour order for Extralight to resolve interpolation error
aaronbell
changed the title
Member
|
Should we be holding off on this because of the comment here:? googlefonts/ufo2ft#402 |
Collaborator
Author
|
I don’t think so. The only downside to implementing the flag everywhere is that freetype will have slightly slower rendering speed. And if freetype eventually changes their approach to this, we can remove the flag implementation entirely. Or if ufo2ft implements it in a smart way, we can switch to that. Either way it benefits users now to have the flag set. |
DHowett
changed the title
DHowett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR modifies the build script to add "OVERLAP_SIMPLE" to normal glyphs and "OVERLAP_COMPOUND" to component glyphs.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Under FreeType, "overlapping contours can produce pixels with inflated coverage because FreeType normally integrates the coverage. To mitigate the artefacts, oversampling is necessary (increase resolution 4x4 and average the results)"
(quote from here). FreeType relies on the "OVERLAP_SIMPLE" and "OVERLAP_COMPOUND" flags to be set to know when this oversampling should take place.
At current, Cascadia does not contain either of these two flags. This fix will add one or the other to every glyph in Cascadia (depending on type of glyph), thus resolving the issue. Once the ufo2ft library adds functionality to address this issue, the build script modification can be removed.
The addition of these flags has no impact on the behavior of the font in Mac or Windows environments.
Before (if applicable) and After Images of the Character(s)
[Before] Note the bottom right corner of the /u and the middle left of the /four:
[After] Displaying properly:
Note that this fix will only work on the cutting edge version of FreeType (to be 2.10.3). The current 2.10.2 stable version does not respect the flags.
For the interpolation error, before:
After:
Validation Steps Performed
Test font reviewed by the bug reporter and found to resolve the problem.
--<rendering checked in FontGoggles