Add Graph Settings#879
Merged
rudyhuyn merged 22 commits intomicrosoft:feature/GraphingCalculatorfrom Jan 3, 2020
rudyhuyn:GraphOptionsV2
Merged
Add Graph Settings#879rudyhuyn merged 22 commits intomicrosoft:feature/GraphingCalculatorfrom rudyhuyn:GraphOptionsV2
rudyhuyn merged 22 commits intomicrosoft:feature/GraphingCalculatorfrom
rudyhuyn:GraphOptionsV2
Conversation
rudyhuyn
added
the
graphing calculator
joseartrivera
requested changes
Dec 18, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Thanks for taking this PR over! Seems to be working well although I did find a few bugs/crashes. Let me know what you think! Thanks again.
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
ghost
added
…es for equations with variables
…tarted fixing the styling on the page.
- Fix crash when users open Graph Settings in high contrast mode - Replace brushes created for the fake Toggle Button in Graph Settings by brushes used in the real ToggleButton
Force a redraw after X/Y Min/Max values are modified
Contributor
Author
|
Rebased! |
joseartrivera
requested changes
Dec 20, 2019
- calculate a proportional range in the ViewModel instead of relying on the graph
joseartrivera
requested changes
Jan 3, 2020
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
joseartrivera
approved these changes
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking over @sanderl's PR.
Description of the changes:
How changes were validated: