Wire up keyboard in graphing calculator#863
Merged
joseartrivera merged 3 commits intomicrosoft:feature/GraphingCalculatorfrom Dec 19, 2019
Merged
Wire up keyboard in graphing calculator#863joseartrivera merged 3 commits intomicrosoft:feature/GraphingCalculatorfrom
joseartrivera merged 3 commits intomicrosoft:feature/GraphingCalculatorfrom
Conversation
EriWong
added
the
graphing calculator
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Great work! This is looking really good, I found a few corner case issues that I think we will want to address, but overall this is looking fantastic! Thanks!
src/Calculator/Views/GraphingCalculator/EquationInputArea.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
EriWong
force-pushed
the
graphingCalcKeyboard
branch
from
a5b7c38 to
f2d4550
Compare
joseartrivera
requested changes
Dec 18, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Great updates, this is working much better. I found a few corner cases for you to consider, lmk what you think! Thanks again.
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingNumPad.xaml.cpp
Outdated
Show resolved
Hide resolved
ghost
added
joseartrivera
approved these changes
Dec 19, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Works great! Congrats on getting this working so nicely 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #338.
Description of the changes:
Wires up on screen keyboard to behave like a SIP for the last focused equation text box.
How changes were validated:
manually