Refactor Equation to be treated as a model and update Key Graph Features#791
Merged
joseartrivera merged 8 commits intomicrosoft:feature/GraphingCalculatorfrom Nov 20, 2019
Conversation
joseartrivera
changed the title
joseartrivera
added
the
graphing calculator
sanderl
reviewed
Nov 15, 2019
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
Outdated
Show resolved
Hide resolved
joseartrivera
changed the title
Contributor
Contributor
sanderl
suggested changes
Nov 19, 2019
ghost
added
the
sanderl
reviewed
Nov 20, 2019
sanderl
approved these changes
Nov 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #338.
Description of the changes:
The current way we transfer data from the EquationViewModel -> Equation is through duplicated dependency properties that are connected via two-way bindings in xaml. This is because the GraphControl was initially designed to receive a DataTemplate where the Equation FrameworkElement was supposed to be used. This isn't an ideal design since a DataTemplate should be able to accept any type of UI but currently would only work when used with the Equation FrameworkElement.
This PR refactors the code so that the GraphControl works more like the MapControl and the MapRouteView class. The GraphControl has a collection of Equations. To add an Equation to the Graph, we would append the equation to that collection and then call the PlotGraph() function.
This PR also updated Key Graph Features to use the new refactored way of transferring data. It was also updated to analyze an equation when the user clicks the button instead of analyzing them all at once.
How changes were validated: