Fix focus for EquationTextBox#787
Merged
joseartrivera merged 1 commit intomicrosoft:feature/GraphingCalculatorfrom Nov 13, 2019
Merged
Fix focus for EquationTextBox#787joseartrivera merged 1 commit intomicrosoft:feature/GraphingCalculatorfrom
joseartrivera merged 1 commit intomicrosoft:feature/GraphingCalculatorfrom
Conversation
joseartrivera
added
the
graphing calculator
sanderl
reviewed
Nov 8, 2019
| void EquationTextBox::OnRichEditBoxGotFocus(Object ^ sender, RoutedEventArgs ^ e) | ||
| { | ||
| m_isFocused = true; | ||
| m_HasFocus = true; |
Contributor
There was a problem hiding this comment.
Is this only for RichEditFocus of for the whole control?
Contributor
Author
There was a problem hiding this comment.
Technically the whole control, but currently we only care when the RichEditBox gets focus
sanderl
approved these changes
Nov 13, 2019
Contributor
sanderl
left a comment
sanderl
left a comment
There was a problem hiding this comment.
I just noticed some weird behavior where tab navigation shows up after pressing enter even if it wasn't used before pressing enter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #338
Description of the changes:
How changes were validated: