Key graph features by sanderl · Pull Request #704 · microsoft/calculator

sanderl · 2019-10-07T21:30:37Z

Description of the changes:

This is a working implementation of Key Graph Features for Graphing Calculator. It is not complete.
Remaining work: Hooking up the KGF EquationEditBox, Error Handling, Rich Edit Styling, Fit and Finish

…ut all strings into the Equation object

…roperties in Equation object

…e UI

…use set text

… from the engine

src/Calculator/Calculator.vcxproj

src/Calculator/Calculator.vcxproj.filters

src/Calculator/Package.appxmanifest

src/GraphControl/GraphControl.vcxproj.filters

src/MockGraphingImpl/MockGraphingImpl.vcxproj

joseartrivera

Nice work! Thanks for digging into this feature! Looking good so far, I left a few comments for you to consider. Thanks again!

src/Calculator/Calculator.vcxproj

src/Calculator/Controls/MathRichEditBox.cpp

src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp

src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml

src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml.cpp

src/GraphControl/Control/Grapher.cpp

joseartrivera

Nice iterations, looks like we are getting pretty close! I have not yet done a buddy build and taken a look at the UI but I can do that on my next pass if you'd like.

src/Calculator/App.xaml

src/Calculator/Controls/MathRichEditBox.cpp

src/GraphControl/Control/Grapher.cpp

src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml

src/GraphingInterfaces/IGraph.h

… TemplateSelector

joseartrivera

Looking good! The new UI design is 🔥. Found a few bugs that shouldn't be too hard to fix, although the root cause is unclear for a few. Let me know what you think! 👍

src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml

src/Calculator/App.xaml

src/Calculator/Resources/en-US/Resources.resw

src/Calculator/App.xaml

src/CalcViewModel/GraphingCalculator/EquationViewModel.cpp

src/CalcViewModel/GraphingCalculator/EquationViewModel.h

src/Calculator/Views/GraphingCalculator/KeyGraphFeaturesPanel.xaml

…projects

…istView

…eColor.Text resource that was mistakenly taken out

src/Calculator/Controls/MathRichEditBox.cpp

src/GraphControl/Control/Grapher.cpp

…ion populated in a new equationtextbox after the previous one was deleted

sanderl added 16 commits July 17, 2019 13:08

Added IGraphAnalyzer

530f2bc

Merged with feature/GraphingCalculator

e23796a

Key Graph Features called and getting returned to the client. To do p…

39809f8

…ut all strings into the Equation object

Updated UpdateKeyGraphFeatures to add function analysis data to all p…

e571935

…roperties in Equation object

Update KGF when variables are updated

2c9dfef

Key graph features ui started

900b9e8

Merge with feature/GraphingCalculator

85fedd9

Added MathRichEditBox and started hooking up key graph features to th…

9670254

…e UI

Updated EquationViewModel to include parity and periodicity

21948ce

Updated key graph features to update the EquationViewModel

16060bd

merged with feature graphing calculator and updated rich edit box to …

93dc298

…use set text

updated key graph features to display more values

024702c

Key graph features populating uing MathRichEdit mode

d147d0f

merged with feature/GraphingCalculator

25bd16b

moved KeyGraphFeatures control to GraphingCalculator.xaml

0f5f013

Use MathML formatting instead of MathRichEdit for strings passed back…

6d42c67

… from the engine

sanderl requested review from DavidShoe and joseartrivera October 7, 2019 21:30