Modify how narrator names the first and last bits of a number in Bit Flip#675
Merged
joseartrivera merged 3 commits intomicrosoft:masterfrom Sep 27, 2019
rudyhuyn:Fix385
Merged
Modify how narrator names the first and last bits of a number in Bit Flip#675joseartrivera merged 3 commits intomicrosoft:masterfrom rudyhuyn:Fix385
joseartrivera merged 3 commits intomicrosoft:masterfrom
rudyhuyn:Fix385
Conversation
Contributor
Author
|
(Let me know if you also want to use "most significant bit") |
Contributor
|
If it is not too much trouble :) |
Contributor
Author
Will do it! It's a little more complicated than LSB (but still simple) because we need to update the text of the checkbox associated to the previous MSB + the new one when we change the bit length. |
rudyhuyn
changed the title
joseartrivera
requested changes
Sep 26, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Thanks for the fix! I tested it out and reviewed the code. Everything seems good. Left a comment about an issue that may or may not be related to this PR. Let me know what you think.
ghost
added
joseartrivera
approved these changes
Sep 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #385
Description of the changes:
How changes were validated: