Update Calc Engine for new functions needed for keyboard refresh#662
Merged
joseartrivera merged 3 commits intomicrosoft:masterfrom Sep 30, 2019
Merged
Conversation
rudyhuyn
reviewed
Sep 11, 2019
Contributor
rudyhuyn
left a comment
rudyhuyn
left a comment
There was a problem hiding this comment.
👏 Good job with this PR! I've added some comments, let me know if you have questions!
joshkoon
reviewed
Sep 20, 2019
sanderl
suggested changes
Sep 24, 2019
ghost
added
the
sanderl
approved these changes
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
Spec for this change can be found here:
Update Calculator keyboard for greater consistency and extensibility
Description of the changes:
This PR includes only the Calc Engine changes for the keyboard refresh spec. The UI portion will be a separate PR.
How changes were validated: