Skip to content

Adds zoom buttons to graph controls#637

Merged
joseartrivera merged 8 commits intomicrosoft:feature/GraphingCalculatorfrom
greedyAI:graphingCalculatorWork
Aug 16, 2019
Merged

Adds zoom buttons to graph controls#637
joseartrivera merged 8 commits intomicrosoft:feature/GraphingCalculatorfrom
greedyAI:graphingCalculatorWork

Conversation

@greedyAI
Copy link
Copy Markdown
Contributor

@greedyAI greedyAI commented Aug 8, 2019

Description of the changes:

  • Zoom-in and zoom-out buttons have been added. When clicked or pressed, they call GraphingControl's ScaleRange function. These buttons take advantage of RepeatButton's API to allow for hold-down repeat click behavior.
  • Zoom reset button has been added. When clicked or pressed, it calls GraphingControl's ResetGrid function.
  • Appropriate keyboard shortcuts and light-mode styling for these buttons have also been added.

How changes were validated:

  • Manual testing.

rudyhuyn
rudyhuyn reviewed Aug 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rudyhuyn rudyhuyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Wei!

I've added a few comments, let me know what you think!

⚠ It seems that your Visual Studio doesn't use XAML Styler (https://marketplace.visualstudio.com/items?itemName=TeamXavalon.XAMLStyler), check that this extension is installed and enabled. Once done, save GraphingCalculator.xaml again to format the XAML code.

@grochocki grochocki added the graphing calculator Work items related to the graphing calculator feature. label Aug 9, 2019
sanderl
sanderl suggested changes Aug 13, 2019
View reviewed changes
joseartrivera
joseartrivera reviewed Aug 13, 2019
View reviewed changes
@ghost ghost removed the needs author feedback label Aug 16, 2019
@joseartrivera joseartrivera merged commit 1c9755d into microsoft:feature/GraphingCalculator Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseartrivera joseartrivera joseartrivera approved these changes

+2 more reviewers

@rudyhuyn rudyhuyn rudyhuyn left review comments

@sanderl sanderl sanderl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joseartrivera joseartrivera

@sanderl sanderl

Labels

graphing calculator Work items related to the graphing calculator feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@greedyAI @rudyhuyn @joseartrivera @sanderl @grochocki