General improvement of the title bar for Always-On-Top.#634
Merged
sanderl merged 6 commits intomicrosoft:masterfrom Aug 23, 2019
rudyhuyn:ImproveTitlebarAOT
Merged
General improvement of the title bar for Always-On-Top.#634sanderl merged 6 commits intomicrosoft:masterfrom rudyhuyn:ImproveTitlebarAOT
sanderl merged 6 commits intomicrosoft:masterfrom
rudyhuyn:ImproveTitlebarAOT
Conversation
sanderl
suggested changes
Aug 21, 2019
Contributor
|
It also looks like there is a conflict in the branch. Can you take a look at that too? |
sanderl
approved these changes
Aug 23, 2019
Contributor
|
Thanks for improvements to AOT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleaning + Make sure issues similar to #587 won't happen with AOT.
Description of the changes:
ExitAlwaysOnTopButtonExitAlwaysOnTopButtonhas the same height than the title bar (the height was fixed)ExitAlwaysOnTopButton(FontWeight, AllowFocusWhenDisabled, Grid.Row)In ApplicationViewModel:
IsAlwaysOnTopIsAlwaysOnTopandDisplayNormalAlwaysOnTopOptionread-onlyHow changes were validated: