Skip to content

General improvement of the title bar for Always-On-Top.#634

Merged
sanderl merged 6 commits intomicrosoft:masterfrom
rudyhuyn:ImproveTitlebarAOT
Aug 23, 2019
Merged

General improvement of the title bar for Always-On-Top.#634
sanderl merged 6 commits intomicrosoft:masterfrom
rudyhuyn:ImproveTitlebarAOT

Conversation

@rudyhuyn
Copy link
Copy Markdown
Contributor

@rudyhuyn rudyhuyn commented Aug 7, 2019

Code cleaning + Make sure issues similar to #587 won't happen with AOT.

Description of the changes:

  • Make TitleBar generic and remove ApplicationViewModel dependency, so other apps can use this control
  • Force the calculation of the title bar visibility when we enter and leave AOT.
  • Use Visual States instead of bindings to manage the 2 states of the title bar.
  • (very) small performance improvement: deferred loading of ExitAlwaysOnTopButton
  • Make sure ExitAlwaysOnTopButton has the same height than the title bar (the height was fixed)
  • Remove the converter and properties not used by ExitAlwaysOnTopButton (FontWeight, AllowFocusWhenDisabled, Grid.Row)

In ApplicationViewModel:

  • Use macro to declare IsAlwaysOnTop
  • Make IsAlwaysOnTop and DisplayNormalAlwaysOnTopOption read-only

How changes were validated:

  • Manually

@grochocki grochocki added the codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) label Aug 9, 2019
@sanderl
Copy link
Copy Markdown
Contributor

sanderl commented Aug 21, 2019

It also looks like there is a conflict in the branch. Can you take a look at that too?

@ghost ghost removed the needs author feedback label Aug 22, 2019
@sanderl sanderl merged commit eb24c08 into microsoft:master Aug 23, 2019
@sanderl
Copy link
Copy Markdown
Contributor

sanderl commented Aug 23, 2019

Thanks for improvements to AOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants