Skip to content

Fixes Always-on-Top crashes in release#626

Merged
joseartrivera merged 1 commit intomicrosoft:masterfrom
greedyAI:always-on-top
Aug 7, 2019
Merged

Fixes Always-on-Top crashes in release#626
joseartrivera merged 1 commit intomicrosoft:masterfrom
greedyAI:always-on-top

Conversation

@greedyAI
Copy link
Copy Markdown
Contributor

@greedyAI greedyAI commented Aug 6, 2019

Description of the changes:

  • Always-on-Top currently crashes in release due to a compiler optimization bug related to co_await's. I've fixed this by turning off compiler optimization for parts of the code that uses co_await's.

How changes were validated:

  • Manual testing.

Related to Issue #560

joseartrivera
joseartrivera previously approved these changes Aug 6, 2019
}
SetDisplayNormalAlwaysOnTopOption();
}
};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the ;

Suggested change
};
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is needed for the compiler to recognize this as a function.

Copy link
Copy Markdown
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
I recommend removing the unnecessary semi-colon before we merge this in though.

@joseartrivera
Copy link
Copy Markdown
Contributor

Closing to restart build

@joseartrivera joseartrivera reopened this Aug 7, 2019
@joseartrivera joseartrivera merged commit 672e881 into microsoft:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants