Skip to content

Remove unused expression item template selector#623

Merged
sanderl merged 2 commits intomicrosoft:masterfrom
rudyhuyn:removeUnusedExpressionItemTemplateSelector
Aug 20, 2019
Merged

Remove unused expression item template selector#623
sanderl merged 2 commits intomicrosoft:masterfrom
rudyhuyn:removeUnusedExpressionItemTemplateSelector

Conversation

@rudyhuyn
Copy link
Copy Markdown
Contributor

@rudyhuyn rudyhuyn commented Aug 6, 2019 •
edited
Loading

Code quality

Description of the changes:

  • Code cleaning:
    • remove unused DataTemplate and ExpressionItemTemplateSelector from Calculator.xaml
    • Replace incorrect ThemeResource references by StaticResource when they don't depend on the currently active theme.

How changes were validated:

  • Manually

@rudyhuyn
Copy link
Copy Markdown
Contributor Author

rudyhuyn commented Aug 6, 2019 •
edited
Loading

Related questions: Why is the result displayed using an extra OverflowTextBlock control in the Always-On-Top mode instead of the existing CalculationResult control? (It should work if set MinFontSize and modify the font size of ScrollLeft and ScrollRight according to the control font size.)

@grochocki grochocki added the codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) label Aug 6, 2019
@sanderl
Copy link
Copy Markdown
Contributor

sanderl commented Aug 20, 2019

Related questions: Why is the result displayed using an extra OverflowTextBlock control in the Always-On-Top mode instead of the existing CalculationResult control? (It should work if set MinFontSize and modify the font size of ScrollLeft and ScrollRight according to the control font size.)

The CalculationResult control has 2 lines of text to show whole calculation, not just the current input. For Always on Top there is no room for the smaller line above the current input, so the control was not used.

@sanderl sanderl merged commit 71b0104 into microsoft:master Aug 20, 2019
@rudyhuyn rudyhuyn deleted the removeUnusedExpressionItemTemplateSelector branch August 21, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanderl sanderl sanderl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@greedyAI greedyAI

@sanderl sanderl

Labels

codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rudyhuyn @sanderl @grochocki @greedyAI