Adding share functionality to Graphing Calculator#601
Merged
sanderl merged 25 commits intomicrosoft:feature/GraphingCalculatorfrom Aug 13, 2019
Merged
Adding share functionality to Graphing Calculator#601sanderl merged 25 commits intomicrosoft:feature/GraphingCalculatorfrom
sanderl merged 25 commits intomicrosoft:feature/GraphingCalculatorfrom
Conversation
…inpage to graphingcalculator
… of a failure. Then add the equations key.
…till need to do the graph equation key.
Feature/graphing calculator update from microsoft master repo.
HowardWolosky
changed the title
HowardWolosky
added
graphing calculator
Contributor
|
@DavidShoe - I don't actually see any file changes as part of the PR... |
added 2 commits
July 25, 2019 17:54
Working -> feature branch so can validate then pull to main project from fork.
ghost
added
the
sanderl
suggested changes
Jul 26, 2019
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
joseartrivera
requested changes
Jul 26, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
David, thank you for working on the share feature. This is looking great so far! I have left some comments for you to review, let me know your thoughts on them. Thanks again for the contribution!
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.h
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.h
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Outdated
Show resolved
Hide resolved
sanderl
approved these changes
Aug 13, 2019
joseartrivera
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes:
Use the new GitBitmap feature from the graph engine to get a stream to the current graph state. Then build up a HMLT share with that and the current set of equations as a key.
How changes were validated:
Manual testing