Skip to content

Fix #563: Odd dependency cycle#570

Merged
HowardWolosky merged 2 commits intomicrosoft:masterfrom
janisozaur:patch-7
Jul 26, 2019
Merged

Fix #563: Odd dependency cycle#570
HowardWolosky merged 2 commits intomicrosoft:masterfrom
janisozaur:patch-7

Conversation

@janisozaur
Copy link
Copy Markdown
Contributor

@janisozaur janisozaur commented Jun 26, 2019

There was no discussion other than lone comment from friendly Microsoft Issue Bot and I'm curious to see what breaks, if anything.

Resolves #563

There was no discussion other than lone comment from friendly Microsoft Issue Bot and I'm curious to see what breaks, if anything.
@janisozaur
Copy link
Copy Markdown
Contributor Author

Yay, nothing broke in tests!

@HowardWolosky HowardWolosky self-assigned this Jun 26, 2019
@HowardWolosky HowardWolosky added the codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) label Jun 26, 2019
@janisozaur
Copy link
Copy Markdown
Contributor Author

Ping. This has been up for almost two weeks without any comments. I'd like to see this merged (or rejected, given sufficient reason) before I work on #544 again, to not let it bitrot again.

@HowardWolosky
Copy link
Copy Markdown
Contributor

Sorry for the delay, @janisozaur -- I have this queued for review this week.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is going to be left empty, should we even bother keeping this method at all, or should we remove all mention of it?

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the function from project if it has no purpose

@HowardWolosky
Copy link
Copy Markdown
Contributor

@janisozaur -- Your analysis seems spot on. Thanks, and nicely done. That being said, I want to bring in @joshkoon since he introduced that destructor during some refactoring back in Oct 2018, and there might be some context there that both of us are missing.

@joshkoon -- This was code you wrote ten months ago, so if you have nothing more to add here, I completely understand. I just thought it might be useful to see if there was a specific scenario that you were trying to account for with calling MemorizedNumberClearAll on destruction (because if so, the fix is likely to clear things out a different way)...

@janisozaur
Copy link
Copy Markdown
Contributor Author

@pi1024e fair point, addressed.

@janisozaur
Copy link
Copy Markdown
Contributor Author

Ping.

@HowardWolosky
Copy link
Copy Markdown
Contributor

I spoke with @joshkoon about this change in-person on Friday, and he believed that it was probably a safe change to make, but thought that verifying behavior in multi-instance scenarios would be worthwhile before merging it in. Since you're on Mac OS, I'll do some local verification today and provided that things look good, we'll merge this in tomorrow.

Copy link
Copy Markdown
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your patience with the validation.

@HowardWolosky HowardWolosky merged commit 60c5c39 into microsoft:master Jul 26, 2019
@janisozaur janisozaur deleted the patch-7 branch January 12, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codebase quality Issues that are not bugs, but still might be worth improving (eg, code hygiene or maintainability) fixing approved issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Odd dependency cycle in CalculatorEngine

3 participants