Drop __inline from conflicting declarations#545
Merged
mcooley merged 1 commit intomicrosoft:masterfrom Jun 10, 2019
Merged
Conversation
`mulnum` et al. are declared `extern` in `ratpak.h`, which conflicts with the `__inline` used with them. Additionally, most similar functions don't have such keyword applied to them.
HowardWolosky
added
the
codebase quality
HowardWolosky
approved these changes
Jun 10, 2019
Contributor
HowardWolosky
left a comment
HowardWolosky
left a comment
There was a problem hiding this comment.
Makes sense. Thanks for the fix!
Contributor
Author
|
The tests seem to be stuck waiting for agent. Can you restart them? |
Contributor
@mcooley is currently working on getting that fixed today. So, this should be able to get merged in later today or tomorrow. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mulnumet al. are declaredexterninratpak.h, which conflictswith the
__inlineused with them. Additionally, most similar functionsdon't have such keyword applied to them.
See
calculator/src/CalcManager/Ratpack/ratpak.h
Lines 463 to 464 in fe30c7c