Add CMake project, GCC support#540
Merged
mcooley merged 4 commits intomicrosoft:masterfrom Jun 6, 2019
Merged
Conversation
This is extract from microsoft#211 that enables compilation with GCC. With microsoft#211 now in the state of bitrot, I would rather try approaching it in smaller steps that can be hopefully merged quicker, even if it does not provide full support for all the features microsoft#211 provided. This will _compile_ correctly with my (@janisozaur) GCC, but clang is more picky about flexible array memebers and refuses to compile it yet. I will extract remaining parts of microsoft#211 in future PRs. I marked @fwcd as author, as he did most of the work in microsoft#211.
janisozaur
force-pushed
the
gcc-port
branch
4 times, most recently
from
322ec0e to
9314d6d
Compare
Contributor
Author
|
I'm happy with the current state of this PR and I will work on extracting the changes to flexible array members next, in future PR. |
mcooley
requested changes
Jun 6, 2019
Member
mcooley
left a comment
mcooley
left a comment
There was a problem hiding this comment.
Thanks for getting this going again! Just a few minor suggestions, and then we can merge this in.
Add missing sal.h include, fix arguments to wcstol
Contributor
Author
|
All done now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extract from #211 that enables compilation with GCC. With #211
now in the state of bitrot, I would rather try approaching it in smaller
steps that can be hopefully merged quicker, even if it does not provide
full support for all the features #211 provided.
This will compile correctly with my (@janisozaur) GCC, but clang is
more picky about flexible array memebers and refuses to compile it yet.
I will extract remaining parts of #211 in future PRs.
I marked @fwcd as author, as he did most of the work in #211.