Unit Converter - Calculate the rounding precision of results based on the source#498
Merged
joseartrivera merged 11 commits intomicrosoft:masterfrom Jul 17, 2019
rudyhuyn:Fix455
Merged
Unit Converter - Calculate the rounding precision of results based on the source#498joseartrivera merged 11 commits intomicrosoft:masterfrom rudyhuyn:Fix455
joseartrivera merged 11 commits intomicrosoft:masterfrom
rudyhuyn:Fix455
Conversation
…he number of significant digits of the result based on that.
rudyhuyn
changed the title
joseartrivera
requested changes
May 15, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Thanks for the awesome contribution! Overall I think this is a better experience, I left a few comments for you to review. Thanks again.
…d don't trim the value when used by the currency converter
rudyhuyn
commented
May 16, 2019
danbelcher-MSFT
suggested changes
May 16, 2019
Contributor
|
ping: @joseartrivera |
ghost
added
the
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. Thank you for your contributions to Windows Calculator! |
joseartrivera
requested changes
Jul 16, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Hi Rudy, sorry for the delay on my response. Just a few small requests before merging this in. Thanks again for taking on this work! :)
Contributor
Author
all done! |
joseartrivera
approved these changes
Jul 16, 2019
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Aug 2, 2019
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Dec 10, 2019
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Dec 10, 2019
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Oct 16, 2021
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Oct 16, 2021
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Sep 25, 2022
janisozaur
added a commit
to janisozaur/calculator
that referenced
this pull request
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455 and #416
Description of the changes:
How changes were validated:
Manually tested, including the 2 repros from #455 and #416