Expand fix for ja era to handle months and days#481
Merged
EriWong merged 1 commit intomicrosoft:masterfrom Apr 30, 2019
Merged
Conversation
EriWong
force-pushed
the
eriwong/471month
branch
2 times, most recently
from
1d0cf42 to
a268148
Compare
HowardWolosky
changed the title
Contributor
EriWong
force-pushed
the
eriwong/471month
branch
2 times, most recently
from
a1896ce to
8536d6b
Compare
Contributor
Author
sanderl
reviewed
Apr 30, 2019
sanderl
reviewed
Apr 30, 2019
sanderl
reviewed
Apr 30, 2019
Expand fix for ja era to handle months and days
EriWong
force-pushed
the
eriwong/471month
branch
from
8536d6b to
adc743a
Compare
sanderl
approved these changes
Apr 30, 2019
EriWong
added a commit
to EriWong/calculator
that referenced
this pull request
Jun 5, 2019
Expand fix for ja era to handle months and days
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
The previous fix only covered how the Calendar control handles years across era boundaries. It turns out the calendar treats the boundary as a month boundary as well. So if the transition across eras happens on the 15th of January, then it considers the 16th of January and the 14th of January to be in different months.
Description of the changes:
How changes were validated: