Skip to content

[JaEra] Calc: subtracting 1-year from date during Reiwa 1 yields unexpected results.#473

Merged
EriWong merged 1 commit intomicrosoft:masterfrom
EriWong:eriwong/471
Apr 24, 2019
Merged

[JaEra] Calc: subtracting 1-year from date during Reiwa 1 yields unexpected results.#473
EriWong merged 1 commit intomicrosoft:masterfrom
EriWong:eriwong/471

Conversation

@EriWong
Copy link
Copy Markdown
Contributor

@EriWong EriWong commented Apr 23, 2019

Fixes 471#.

[JaEra] Calc: subtracting 1-year from date during Reiwa 1 yields unexpected results.

Description of the changes:

  • When doing addition or subtraction of dates, if using the Japanese Era Calendar system, use the gregorian system to perform year addition/subtraction.

How changes were validated:

  • Manually verified that the transition between Reiwa and Heisei eras are handled correctly
  • Wrote tests covering an already established era transition between Heisei and Showa eras.

[JaEra] Calc: subtracting 1-year from date during Reiwa 1 yields unexpected results.
@EriWong EriWong merged commit 1dee9dc into microsoft:master Apr 24, 2019
EriWong added a commit to EriWong/calculator that referenced this pull request Jun 5, 2019
[JaEra] Calc: subtracting 1-year from date during Reiwa 1 yields unexpected results.
@EriWong EriWong deleted the eriwong/471 branch November 17, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants