Fix test code that never executes#465
Merged
HowardWolosky merged 2 commits intomicrosoft:masterfrom Apr 19, 2019
Merged
Conversation
Test code never executes - ill defined loop
EriWong
commented
Apr 18, 2019
HowardWolosky
added
fixing approved issue
codebase quality
HowardWolosky
suggested changes
Apr 18, 2019
Contributor
HowardWolosky
left a comment
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks Eric. I agree with you that we should just remove the loop in this instance.
HowardWolosky
approved these changes
Apr 19, 2019
Contributor
HowardWolosky
left a comment
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks for the fix!
EriWong
added a commit
to EriWong/calculator
that referenced
this pull request
Jun 5, 2019
Fixes microsoft#175. Fixes loop in test code to verify that commands not supported by the unit converter viewmodel result in no-op. Description of the changes: Removed loop of range of enums with a being tested for no-ops since it added no intrinsic value (and the way that the range was handled was incorrect). Considered adding an iterator over a static list of commands to validate against, but determined it didn't add any notable value. How changes were validated: Ran modified test to ensure it passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test code never executes - ill defined loop
Fixes #175.
Fixes loop in test code to verify that commands not supported by the unit converter viewmodel result in no-op.
Description of the changes:
Replaced loop of range of enums with a list of all currently supported commands in check that those commands are no-ops.
How changes were validated:
Ran modified test to ensure it passes