Fix #407: Removed AppBar, OperatorTextBox and OperandTextBox controls#440
Fix #407: Removed AppBar, OperatorTextBox and OperandTextBox controls#440danbelcher-MSFT merged 5 commits intomicrosoft:masterfrom
Conversation
|
|
danbelcher-MSFT
left a comment
danbelcher-MSFT
left a comment
There was a problem hiding this comment.
Hey @jatinkumarg, it seems like after these changes we can also remove:
https://github.com/Microsoft/calculator/blob/47a27412188da14af410a9c28885ee8d51fa35b8/src/Calculator/Views/MainPage.xaml.h#L73
https://github.com/Microsoft/calculator/blob/47a27412188da14af410a9c28885ee8d51fa35b8/src/CalcViewModel/ApplicationViewModel.h#L69
https://github.com/Microsoft/calculator/blob/47a27412188da14af410a9c28885ee8d51fa35b8/src/CalcViewModel/ApplicationViewModel.cpp#L39
https://github.com/Microsoft/calculator/blob/47a27412188da14af410a9c28885ee8d51fa35b8/src/CalcViewModel/StandardCalculatorViewModel.h#L89
|
@danbelcher-MSFT My recent commit got Do you know if it's because of my code or azure server issue? |
|
I'm not sure. You can go to the 'Checks' tab and re-run the check: |
|
It doesn't give me an option to
|
|
I had already tried re-running for you but the build has been queued for 17 minutes now. We think the PR hit a bug in Azure Pipelines. We'll contact the team tomorrow to do more investigation. Sorry about the trouble! |
|
Closing and reopening to hopefully get the pipeline out of a bad state... |
|
@jatinkumarg, looks like the build works now. You have some build errors to fix and then we can get your change merged. Thanks @mcooley! |
|
@danbelcher-MSFT Everything seems fine now. Let me know if there are any further changes required. |
…t#440) Fixes microsoft#407 Removed AppBar, OperatorTextBox and OperandTextBox controls
5 participants
Removed AppBar, OperatorTextBox and OperandTextBox controls