Skip to content

Added WinAppDriver UI Tests to the Calculator Project.#411

Merged
mcooley merged 7 commits intomicrosoft:masterfrom
hassanuz:wad
Apr 25, 2019
Merged

Added WinAppDriver UI Tests to the Calculator Project.#411
mcooley merged 7 commits intomicrosoft:masterfrom
hassanuz:wad

Conversation

@hassanuz
Copy link
Copy Markdown
Contributor

@hassanuz hassanuz commented Mar 29, 2019 •
edited by mcooley
Loading

Summary

This pull requests adds WinAppDriver UI tests onto the Calculator project. Nothing in the Calculator source itself was modified outside of introducing the *\src\CalculatorWADTests* directory with the added WinAppDriver solution.

How changes were validated:

  • The tests were validated on my local machine & on the hosted VS2019 agent.

Fixes #461

@mcooley mcooley self-assigned this Apr 1, 2019
mcooley
mcooley requested changes Apr 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mcooley mcooley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @hassanuz! I'm excited to get some UI tests in Calculator that others will be able to run. A few requests for changes, most of them fairly minor.

TODO for me: get an issue filed for this Done! #461

sanderl
sanderl reviewed Apr 3, 2019
View reviewed changes
sanderl
sanderl previously requested changes Apr 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanderl sanderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

mcooley
mcooley reviewed Apr 16, 2019
View reviewed changes
@mcooley
Copy link
Copy Markdown
Member

mcooley commented Apr 25, 2019

@hassanuz I pushed some changes:

  • Integrated your work into our existing builds, so UI tests get run for PR and CI
  • Switch from .NET Framework to .NET Core
  • Switch to the official Appium.WebDriver NuGet package
  • Remove "Any CPU" as a solution configuration
  • Simplify inline powershell in the YAML

I think this is ready to merge now! @sanderl can you review again and make sure this looks OK to you?

@mcooley mcooley requested a review from sanderl April 25, 2019 14:01
@mcooley mcooley dismissed sanderl’s stale review April 25, 2019 23:45

Dismissing stale review.

@mcooley mcooley merged commit 8e1a147 into microsoft:master Apr 25, 2019
EriWong pushed a commit to EriWong/calculator that referenced this pull request Jun 5, 2019
@hassanuz @EriWong
Added WinAppDriver UI Tests to the Calculator Project. (microsoft#411)
cbc33f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcooley mcooley mcooley approved these changes

@sanderl sanderl Awaiting requested review from sanderl

Assignees

@mcooley mcooley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add UI tests using WinAppDriver

3 participants

@hassanuz @mcooley @sanderl