Fix #409 and #59 - UI issues with UnitConverter in RtL#410
Merged
danbelcher-MSFT merged 4 commits intomicrosoft:masterfrom Apr 20, 2019
rudyhuyn:UnitRTL
Merged
Fix #409 and #59 - UI issues with UnitConverter in RtL#410danbelcher-MSFT merged 4 commits intomicrosoft:masterfrom rudyhuyn:UnitRTL
danbelcher-MSFT merged 4 commits intomicrosoft:masterfrom
rudyhuyn:UnitRTL
Conversation
…rly in RtL Fix #59 Currency symbol precedence is opposite of system setting in RTL languages
danbelcher-MSFT
approved these changes
Apr 20, 2019
danbelcher-MSFT
left a comment
danbelcher-MSFT
left a comment
There was a problem hiding this comment.
Users of intl.cpl will appreciate this :) Thanks, Rudy!
EriWong
pushed a commit
to EriWong/calculator
that referenced
this pull request
Jun 5, 2019
Fix microsoft#409 - Some content in Currency Converter not right-aligned properly in RtL Fix microsoft#59 Currency symbol precedence is opposite of system setting in RTL languages Description of the changes: Add a property FlowDirectionHorizontalAlignment in UnitConverter to align some controls to the right (without modifying the FlowDirection of their parent items) Force FlowDirection of Value1Container and Value2Container to LeftToRight (but align panels to the right) How changes were validated: Tested with LtR and RtL languages and with currency symbols on the left and on the right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #409 - Some content in Currency Converter not right-aligned properly in RtL
Fix #59 Currency symbol precedence is opposite of system setting in RTL languages
Description of the changes:
FlowDirectionHorizontalAlignmentin UnitConverter to align some controls to the right (without modifying theFlowDirectionof their parent items)How changes were validated:
Screenshots:
LtR with currency symbol on the left
LtR with currency symbol on the right
RtL with currency symbol on the left
RtL with currency symbol on the right
