Skip to content

Prevent the application to crash when the current page is Date Calculation and users paste a text#391

Merged
HowardWolosky merged 2 commits intomicrosoft:masterfrom
rudyhuyn:Fix389
Apr 15, 2019
Merged

Prevent the application to crash when the current page is Date Calculation and users paste a text#391
HowardWolosky merged 2 commits intomicrosoft:masterfrom
rudyhuyn:Fix389

Conversation

@rudyhuyn
Copy link
Copy Markdown
Contributor

Fixes #389

Description of the changes:

  • Fix the else condition in ApplicationViewModel::OnPaste

How changes were validated:

Manually

Copy link
Copy Markdown
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I checked the file, and it doesn't look like there are any other instances where we might hit this. Thanks again.

@HowardWolosky HowardWolosky self-assigned this Mar 27, 2019
@HowardWolosky
Copy link
Copy Markdown
Contributor

@rudyhuyn - Just looking for a minor update to this, and then we can get it merged in.
Thanks!

Co-Authored-By: rudyhuyn <[email protected]>
Copy link
Copy Markdown
Contributor

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that update.

@HowardWolosky HowardWolosky merged commit 5a6c6f4 into microsoft:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The application crashes when users press ctrl+V while displaying the Date Calculation page.

2 participants