Keep input when users refresh currency rates#369
Merged
danbelcher-MSFT merged 5 commits intomicrosoft:masterfrom Apr 16, 2019
rudyhuyn:Fix260
Merged
Keep input when users refresh currency rates#369danbelcher-MSFT merged 5 commits intomicrosoft:masterfrom rudyhuyn:Fix260
danbelcher-MSFT merged 5 commits intomicrosoft:masterfrom
rudyhuyn:Fix260
Conversation
|
@rudyhuyn, looks like UTs are failing. |
danbelcher-MSFT
suggested changes
Apr 11, 2019
danbelcher-MSFT
left a comment
danbelcher-MSFT
left a comment
There was a problem hiding this comment.
Hey Rudy, I think the change looks good. I just have a minor comment about style.
EriWong
pushed a commit
to EriWong/calculator
that referenced
this pull request
Jun 5, 2019
Fixes microsoft#260 Description of the changes: prevent UnitConverterViewModel to reset values when users click on update rates. recompute UnitConverter's caches (m_ratioMap and m_categoryToUnits) once rates are updated (but check first if the user did/didn't change the category) How changes were validated: Manually tested with fake currency rates (HTTP responses modified on the fly via FiddlerCore) Verified that it works no matter the selected field (From or To) Verified that the currencies selected are kept after a refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260
Description of the changes:
UnitConverterViewModelto reset values when users click onupdate rates.m_ratioMapandm_categoryToUnits) once rates are updated (but check first if the user did/didn't change the category)How changes were validated:
FromorTo)