Improve the support of Narrator with parenthesis#368
Merged
joseartrivera merged 4 commits intomicrosoft:masterfrom Apr 15, 2019
rudyhuyn:Narrator
Merged
Improve the support of Narrator with parenthesis#368joseartrivera merged 4 commits intomicrosoft:masterfrom rudyhuyn:Narrator
joseartrivera merged 4 commits intomicrosoft:masterfrom
rudyhuyn:Narrator
Conversation
joseartrivera
requested changes
Apr 1, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I took a first pass and left some comments for you to take a look at.
src/Calculator/Views/CalculatorProgrammerRadixOperators.xaml.cpp
Outdated
Show resolved
Hide resolved
src/Calculator/Views/CalculatorProgrammerRadixOperators.xaml.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@joseartrivera let me know if you need other changes! |
joseartrivera
approved these changes
Apr 15, 2019
Contributor
|
Thanks Rudy, this change is a great improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367
Description of the changes:
(or)button when they get the focusViewModel::PropertyChangedwhen possible, ideally, for performance reasons, we should only use bindings or specialized events.Format_OpenParenthesisAutomationNamePrefixto unify the behavior with the right parenthesis button and not repeat the name of the button each time the user clicks on it.How changes were validated: