Fix bug when the negate sign is before a space #345
Merged
joseartrivera merged 3 commits intomicrosoft:masterfrom Apr 26, 2019
rudyhuyn:Fix294
Merged
Fix bug when the negate sign is before a space #345joseartrivera merged 3 commits intomicrosoft:masterfrom rudyhuyn:Fix294
joseartrivera merged 3 commits intomicrosoft:masterfrom
rudyhuyn:Fix294
Conversation
HowardWolosky
added
fixing approved issue
Behavior Change
Bug
mauve
reviewed
Mar 26, 2019
| updatedToken = CCalcEngine::OpCodeToUnaryString(static_cast<int>(Command::CommandLN), true, angleType); | ||
| break; | ||
| default: | ||
| updatedToken = CCalcEngine::OpCodeToUnaryString(nOpCode, false, angleType); |
There was a problem hiding this comment.
something screwed up the indentation of this switch-case
joseartrivera
previously approved these changes
Apr 1, 2019
Contributor
joseartrivera
left a comment
joseartrivera
left a comment
There was a problem hiding this comment.
The change looks good to me and functions correctly. Thanks for fixing this! Just need to adjust the formatting as mentioned earlier by @mauve
Contributor
|
Hey @rudyhuyn I signed off on this, but could you fix the formatting before I merge it in? Thanks! |
joseartrivera
approved these changes
Apr 26, 2019
EriWong
pushed a commit
to EriWong/calculator
that referenced
this pull request
Jun 5, 2019
* Ignore None characters while parsing the clipboard * reformat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294
Description of the changes:
Ignore
Nonecharacters while parsing the clipboard, so '4--6' would be correctly interpreted.The issue was that
isPreviousOperatorwas set toFalsebecause of the space character, ignore it solve the issue.How changes were validated: