Replace custom ARRAYSIZE macro with std::size#208
Merged
danbelcher-MSFT merged 2 commits intomicrosoft:masterfrom Mar 15, 2019
Merged
Replace custom ARRAYSIZE macro with std::size#208danbelcher-MSFT merged 2 commits intomicrosoft:masterfrom
danbelcher-MSFT merged 2 commits intomicrosoft:masterfrom
Conversation
danbelcher-MSFT
suggested changes
Mar 8, 2019
danbelcher-MSFT
suggested changes
Mar 8, 2019
046eca8 to
7b5b6b4
Compare
Contributor
Author
|
Updated |
Contributor
Author
|
Ping @danbelcher-MSFT, this should be ready for merging |
danbelcher-MSFT
approved these changes
Mar 15, 2019
danbelcher-MSFT
left a comment
There was a problem hiding this comment.
Thanks for the code improvement. Looking forward to that pch conversation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.