-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Incorrect currency ratio equality when low valued unit converted to high valued #252
Copy link
Copy link
Closed
Labels
Area: User ExperienceIssue primarily affects end user experience and are not covered by other areasIssue primarily affects end user experience and are not covered by other areasPri: 2fixed
Description
Describe the bug
Converter rounds/truncates rate to 4 decimal places, therefore currency ratio of low valued units such iranian rial or indonesian rupiah compared to highly valued units like US dollars displayed incorrectly.
Steps To Reproduce
- Launch the calculator
- Open the currency converter
- Select Iranian rial as first unit and US dollar as second.
- See today's exchange rate.
Expected behavior
Ideally ratio should be rounded appropriately, not too much and not too little. Basically converters round it to 6 decimals. E.g 1 IRR = 0.000024 USD
Device and Application Information (please complete the following information):
- OS Build: 17763
- Architecture: X64
- Application Version: 10.1812.10048.0
Additional context
Possible solution in:
- https://github.com/Microsoft/calculator/blob/0f615faff93dc11101f6b730ce46c69f5390b94c/src/CalcViewModel/DataLoaders/CurrencyDataLoader.cpp#L42
- https://github.com/Microsoft/calculator/blob/0f615faff93dc11101f6b730ce46c69f5390b94c/src/CalcViewModel/DataLoaders/CurrencyDataLoader.cpp#L281
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area: User ExperienceIssue primarily affects end user experience and are not covered by other areasIssue primarily affects end user experience and are not covered by other areasPri: 2fixed
