Android test variant support #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This has been branched from android-support branch. I will rebase once #173 is merged. |
Changes: - Updated AndroidUtils to populate all fields individually so failure in retrieval of one property won't lead to the collapse of whole source set. - Added android resource directories only if the variant is not a unit test - Updated GradleApiConnectorTest#testAndroidSourceSets to consider the all the test variants and their dependencies - Addressed checkstyle issues
Tanish-Ranjan
force-pushed
the
feat/android-support-tests
branch
from
4542f3b to
47dfa24
Compare
Contributor
Author
|
Tested the changes with default test project by integrating with vscode-gradle extension. The test variants were retrieved successfully. |
jdneo
reviewed
Sep 6, 2024
plugin/src/main/java/com/microsoft/java/bs/gradle/plugin/utils/AndroidUtils.java
Show resolved
Hide resolved
Changes: - AndroidUtils#convertVariantToGradleSourceSet now returns a list of source sets rather than a single source set. - AndroidUtils#addTests now returns a list of test source sets.
jdneo
approved these changes
Sep 13, 2024
Member
|
Thank you for your contribution! @Tanish-Ranjan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #183, this PR discovers all the test variants and adds them to the source sets.