Skip to content

fix: [#4684] ESLint issues in botframework-streaming #4825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tracyboehrer merged 3 commits into from
Jan 6, 2025
Merged

fix: [#4684] ESLint issues in botframework-streaming #4825

tracyboehrer merged 3 commits into from
Jan 6, 2025

Conversation

@sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented Dec 20, 2024

Addresses #4684
#minor

Description

This PR fixes all the new ESLint errors and warnings that appeared after the ESLint packages' upgrade in the botframework-streaming project.

Specific Changes

  • Removed 'only-warn' plugin from 'botframework-streaming/eslint.config.cjs' and its dependency.
  • All updated TS and JS files were due to prettier, mocha, and jsdoc new rules.
  • We replaced all test assertions that use expect(...).to.be.undefined / to.be.true / to.be.false, to to.equal(undefined | true | false) due to mocha rule.
  • Separated a few tests describe in different files due to mocha rule.

Testing

The following image shows that there are no more ESLint issues, and the tests are passing after the changes.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner December 20, 2024 13:07
@coveralls
Copy link

coveralls commented Dec 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12431991684

Details

  • 23 of 24 (95.83%) changed or added relevant lines in 12 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 84.625%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-streaming/src/webSocket/browserWebSocket.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/nodeWebSocket.ts 1 87.76%
libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts 1 45.0%
libraries/botframework-streaming/src/webSocket/browserWebSocket.ts 1 42.42%
libraries/botframework-streaming/src/contentStream.ts 1 75.0%
Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20513
Relevant Lines: 23091
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 8d39ef5 into main Jan 6, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botframework-streaming branch January 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sw-joelmut @coveralls @tracyboehrer