Skip to content

Conversation

@JhontSouth
Copy link
Contributor

@JhontSouth JhontSouth commented Dec 19, 2024

#minor

Description

This PR updates the p-map package to the latest version and applies the necessary configuration to keep the compatibility in every library.

Specific Changes

  • Updated p-map to version ^7.0.3.
  • Added prebuild scripts to botbuilder-azure and botbuilder-azure-blobs to use tsup to compile ESM-only package.
  • Updated imports of p-map in every class.
  • Removed p-map from botbuilder-repo-utils.

Testing

The following images show the botbuilder-azure and botbuilder-azure-blobs unit tests working after the updates.
image
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 19, 2024 13:33
@coveralls
Copy link

coveralls commented Dec 19, 2024

Pull Request Test Coverage Report for Build 12636582722

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.618%

Totals Coverage Status
Change from base Build 12635070225: 0.0%
Covered Lines: 20517
Relevant Lines: 23098

💛 - Coveralls

@ceciliaavila
Copy link
Collaborator

@tracyboehrer , conflicts were solved in this PR.

@tracyboehrer tracyboehrer merged commit 29ae34b into main Jan 24, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/p-map branch January 24, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants