Skip to content

Conversation

@ceciliaavila
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR fixes the new ESLint errors and warnings after upgrading the ESLint packages in the botbuilder-stdlib project.

Specific Changes

  • Removed the botbuilder-dialogs-declarative/eslint.config.cjs' file as it contained only the 'only-warn' plugin which was no longer needed.
  • Applied the auto fix flag for most issues (trailing commas and removal of unnecessary eslint exceptions).
  • Applied manual fixes for skipping the new rule 'no-unsafe-function-type'.

Testing

The following images show the number of issues fixed in the project.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 11, 2024 11:18
@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12275263385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.625%

Totals Coverage Status
Change from base Build 12259066809: 0.0%
Covered Lines: 20513
Relevant Lines: 23091

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit df3b3f5 into main Jan 6, 2025
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-stdlib branch January 6, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants