Skip to content

Conversation

@ceciliaavila
Copy link
Collaborator

#minor

Description

This PR ports the changes from BotBuilder-DotNet's PR#6867 to handle eTag conflicts on concurrent calls to the BlobsStorage write method.

Specific Changes

  • Added a try-catch block to handle the 412 error code in the write method of BlobsStorage class.
  • Added a unit test to cover this scenario in blobsStorage.tests.js.

Testing

This image shows the new unit tests working.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner November 22, 2024 11:48
@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11972005034

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.689%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-azure-blobs/src/blobsStorage.ts 0 8 0.0%
Totals Coverage Status
Change from base Build 11687414604: -0.02%
Covered Lines: 20515
Relevant Lines: 23068

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 203c044 into main Nov 22, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/manage-error-412 branch November 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants