bump: [#4684] Upgrade filenamify using import-sync for esm-only package #4782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libraries/botbuilder/package.json # libraries/botframework-connector/package.json # package.json # yarn.lock
Pull Request Test Coverage Report for Build 11629057880Details
💛 - Coveralls |
tracyboehrer
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4684
#minor
Description
This PR updates the
filenamifypackage to its latest version 6.0.0. Starting on version 5.x, this package is ESM-only, so we used import-sync to be able to use this version.Specific Changes
filenamifyfrom 4.3.0 and 6.0.0 in botbuilder library.import-syncas a dependency in botbuilder.fileTranscriptStoreclass to import the package filenamify using the importSync function.Testing
The following images show the installed version and the unit tests passing after the changes.
