Skip to content

refactor: [#4684] Replace browserify with tsup #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tracyboehrer merged 6 commits into from
Oct 29, 2024
Merged

refactor: [#4684] Replace browserify with tsup #4774

tracyboehrer merged 6 commits into from
Oct 29, 2024

Conversation

@sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented Oct 21, 2024

Addresses #4684
#minor

Description

This PR removes browserify from the repo and replaces it with tsup.

Specific Changes

  • Moved the existing tsup config from botframework-connector to the root of the repo, to be shared among all libraries.
  • Replaced browserify dependency from botframework-streaming, adaptive-expressions and adaptive-expressions-ie11 with tsup, removing unnecessary dependencies and scripts.
  • Removed babel-traverse resolution, as esmify was removed and no longer necessary.

Testing

The following image shows the browser import logs, and the browser-echo-bot working.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 21, 2024 13:04
@coveralls
Copy link

coveralls commented Oct 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11577891426

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.5%) to 84.703%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/disassemblers/httpContentStreamDisassembler.ts 1 90.0%
libraries/botframework-streaming/src/disassemblers/requestDisassembler.ts 1 63.89%
libraries/botframework-streaming/src/payloads/streamManager.ts 1 73.17%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 1 68.6%
libraries/botframework-streaming/src/payloadTransport/payloadSender.ts 1 77.42%
libraries/botframework-streaming/src/payloads/requestManager.ts 1 86.67%
libraries/botframework-streaming/src/disassemblers/responseDisassembler.ts 1 77.78%
libraries/botframework-streaming/src/payloadTransport/payloadReceiver.ts 1 78.87%
libraries/botframework-streaming/src/disassemblers/payloadDisassembler.ts 2 87.5%
libraries/botframework-streaming/src/protocolAdapter.ts 3 85.71%
Totals Coverage Status
Change from base Build 11575805257: -0.5%
Covered Lines: 20514
Relevant Lines: 23063
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 84dc7e4 into main Oct 29, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/tsup-adaptive-expressions branch October 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sw-joelmut @coveralls @tracyboehrer