bump: [#4684] Replace nanoid with native module crypto #4769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11576505677Details
💛 - Coveralls |
tracyboehrer
approved these changes
Oct 29, 2024
Collaborator
Author
|
@tracyboehrer, conflicts solved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4684
#minor
Description
This PR replaces the micro-library
nanoidwith the native module crypto to generate a random ID. Nanoid can't be upgraded as, in its latest version, it is an ESM-only package.Specific Changes
botbuilder-test-utils/jwt.tsreplacing the use of nanoid with crypto.Testing
The following image shows the unit tests passing after the change.
