Skip to content

Conversation

@sw-joelmut
Copy link
Collaborator

Related issue #4746
#minor

Description

This PR adds TypeScript 5.6 and ESNext target support for the test:consumer script.
The FunctionTable inside the adaptive-expressions project has been updated to support both es6 and esnext targets, alongside, lodash.isequal has been replaced for lodash, updating the import statement.

Specific Changes

  • Updated adaptive-expressions package.json, adding typesVersions with custom types for versions below 5.6.
  • Replaced lodash.isequal for lodash.
  • Updated FunctionTable class, changing IterableIterator for MapIterator due to the combination of TS 5.6 and ESNext requires using MapIterator.
    • To address this disparity, we created a MapIterator type that extends from IterableIterator for all versions of TS below 5.6.
  • Updated test:consumer script, adding TS 5.6 and ESNext target.

Testing

The following image shows the test:consumer script working with all TS versions, and es6 and ESNext targets.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 3, 2024 12:58
@coveralls
Copy link

coveralls commented Oct 3, 2024

Pull Request Test Coverage Report for Build 11162438364

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 85.349%

Totals Coverage Status
Change from base Build 11162009523: 0.4%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit e22bdfa into main Oct 3, 2024
@tracyboehrer tracyboehrer deleted the southworks/add/ts5.6-esnext branch October 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants