Skip to content

bump: [#4684] Update multiple dependencies inside public libraries to latest version #4739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tracyboehrer merged 5 commits into from
Sep 10, 2024
Merged

bump: [#4684] Update multiple dependencies inside public libraries to latest version #4739

tracyboehrer merged 5 commits into from
Sep 10, 2024

Conversation

@sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented Sep 9, 2024

Addresses #4684
#minor

Description

This PR updates multiple dependencies that are used inside all public libraries (botbuilder-core, botbuilder-ai, botframework-connector, etc.) to their latest version.
Additionally, added minimal support for @types/node 18 and typescript 4.7.

Specific Changes

  • New version of @types/node and typescript introduced new types, and new validations.
  • Removed get-stream dependency to use stream/consumers instead.
  • Added a TODO to address the INodeSocket type problem in its own PR, that impacts streaming and adapters.
  • Some dependencies updates were left outside this PR as they have problems and to tackle them in their own PR.
  • The rest of the dependencies were updated correctly to their latest version.

Testing

The following images show the bf-connector browser, and the new stream/consumers implementation working.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner September 9, 2024 13:06
@coveralls
Copy link

coveralls commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10773845170

Details

  • 23 of 31 (74.19%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.004%) to 84.407%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts 0 2 0.0%
libraries/botbuilder-azure-blobs/src/blobsStorage.ts 1 4 25.0%
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-azure-blobs/src/blobsStorage.ts 1 44.32%
libraries/botbuilder-azure/src/azureBlobTranscriptStore.ts 1 85.77%
libraries/botbuilder-azure/src/blobStorage.ts 1 86.67%
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 2 15.92%
Totals Coverage Status
Change from base Build 10582319010: 0.004%
Covered Lines: 20433
Relevant Lines: 22910
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit a3fc96e into main Sep 10, 2024
@tracyboehrer tracyboehrer deleted the southworks/update/public-dependencies branch September 10, 2024 13:51
This was referenced Oct 30, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 6, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sw-joelmut @coveralls @tracyboehrer