bump: [#4550] Add Node 18 and 20 support #4726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10531815490Details
💛 - Coveralls |
tracyboehrer
approved these changes
Aug 26, 2024
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4550
Fixes #4709
Important
Node 14 and 16 versions have been removed from the testing pipeline execution due to packages that require newer versions of Node and don't support them.
Description
This PR updates
@microsoft/orchestrator-corefrom4.14.4to4.15.1that was preventing Node 18+ installations due to non-existing binaries available for them.Additionally, it adds support for Node 18 and 20 versions to allow installation of newer versions of packages like Azure Identity and MSAL that have Node 18+ limitation.
We updated all pipelines to target the latest LTS Node version, and for the testing one we also included Node 18 and above.
Specific Changes
test:schemaspipeline due to having the Orchestrator-Core limitation yet.@microsoft/orchestrator-corefrom4.14.4to4.15.1that support newer versions of node.@azure/msal-nodeto latest2.13.0version.@azure/identityto latest4.4.1version. Fixing CVE-2024-35255.browserifywithtsupinbotframework-connector.Testing
The following images show the new
botframework-connectorbrowser compilation, the MultiTenant, SingleTenant, Certificate, and MSI type of authentications working.