fix: Remove CVE-2020-8203 vulnerability in lodash.set #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
Jul 1, 2024
Pull Request Test Coverage Report for Build 9764339588Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9764339588Details
💛 - Coveralls |
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4684
#minor
Description
This PR addressess the CVE-2020-8203 vulnerability affecting [email protected] by removing the @types/nock package which depends on [email protected].
[email protected] and beyond provides its own type definitions, and
@types/nockis no longer necessary.Specific Changes
botbuilder-dialogs-adaptive-testingTesting
The following image shows lodash.set being removed after the update:
The following image shows
botbuilder-dialogs-adaptive-runtimetests passing: