fix: Remove CVE-2022-25881 vulnerability by updating the http-cache-semantics package #4703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
Jul 1, 2024
Pull Request Test Coverage Report for Build 9762746690Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9762746690Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9763576686Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4684
#minor
Description
This PR updates the version of the
http-cache-semanticspackage to4.1.1to fix the CVE-2022-25881 vulnerability.Along the way, to address this
http-cache-semanticspackage issue with 3.x version, we removed bf-chatdown package, and ported its code to botbuilder-core as internal testing, to remove unnecessary vulnerable dependencies the project isn't using.Additionally, the lodash.template https://github.com/microsoft/botbuilder-js/security/dependabot/344 - CVE-2021-23337 was also address.
Specific Changes
http-cache-semanticsto4.1.1.bf-chatdownas it was usinghttp-cache-semantics3.x version.bf-chatdowncode tobotbuilder-corefor internal testing.transcriptstests to work with latest botbuilder changes.transcriptstests to the testing flow.chatdownandbotbuilder-dialogs-adaptive.Testing
The following image shows the
http-cache-semanticsupdated version, and thetrascriptstests passing.