fix: CodeQL SM04509 issue #4671
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9370201661Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9370201661Details
💛 - Coveralls |
tracyboehrer
approved these changes
Jun 4, 2024
This was referenced Jul 18, 2024
This was referenced Jul 28, 2024
This was referenced Sep 7, 2024
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR removes
eval()from the botbuilder-lg package.There is no need for side-effects at execution time for the
nullSubstitutionlambda function.Additionally, the related CodeQL and ESLint suppressions have been removed, as there is no use for them anymore.
Specific Changes
eval()code.security/detect-eval-with-expression.@typescript-eslint/no-unused-vars.Testing
The following image shows
EvaluationOptionstests passing (along with all other tests).