Skip to content

Conversation

@JhontSouth
Copy link
Contributor

#minor

Description

This PR includes the HTTP method post to the fetch request.

Specific Changes

  • Added post method to the fetch request in botFrameworkClientImpl.
  • Imported fetch from cross-fetch.
  • Removed the body parse.

Testing

The following image shows a skill bot working using CloudAdapter with the botframework-connector fix.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 22, 2023 15:03
@coveralls
Copy link

coveralls commented Dec 22, 2023

Pull Request Test Coverage Report for Build 7301216761

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.541%

Totals Coverage Status
Change from base Build 7292822578: 0.0%
Covered Lines: 20416
Relevant Lines: 22872

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 709a823 into main Dec 22, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/add-fetch-http-method branch December 22, 2023 16:31
tracyboehrer pushed a commit that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants