fix: [#4544] JwtTokenExtractor.getIdentity:err! FetchError: request to https://login.botframework.com/v1/.well-known/openidconfiguration #4583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7573729133
💛 - Coveralls |
Collaborator
Author
|
Closing as a better alternative was found and documented in this comment. |
Collaborator
Author
|
Reopened in consideration of a new customer's scenario (link). |
tracyboehrer
approved these changes
Jan 18, 2024
tracyboehrer
pushed a commit
that referenced
this pull request
Jan 24, 2024
…https://login.botframework.com/v1/.well-known/openidconfiguration (#4583) * Provide proxy setting to openIdMetadata * Replace @azure/ms-rest-js with @azure/core-http * Add missing agent settings in getKeys call
This was referenced Jul 18, 2024
This was referenced Sep 7, 2024
This was referenced Oct 30, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4544
Description
This PR fixes the error thrown in openIdMetadata when the bot is used behind a proxy server by setting the proxy's URL in the fetch agent.
Specific Changes
parameterizedBotFrameworkAuthenticationto pass the proxy settings to jwtTokenExtractor.jwtTokenExtractorto pass the proxy settings to openIdMetadata.openIdMetadato set the agent in the fetch, containing the proxy URL.cross-fetchwithnode-fetchto pass the agent option.Testing
We tested this using different tools to simulate HTTP and HTTPS proxies.
These images show the request intercepted by the proxy and the bot working.